HI Jeff,

another question: 
unsigned int ata_dev_classify(struct ata_taskfile *tf) 

in drivers/scsi/libata-core.c doesn't have access to an ata_port struct and it 
thus cannot be converted to the new ata_msg_xxx usage. However, this function 
has only two users which both have ata_port defined in their function bodies. 
Should I change the interface of ata_dev_classify from 

unsigned int ata_dev_classify(struct ata_taskfile *tf)

to 

unsigned int ata_dev_classify(struct ata_taskfile *tf, struct ata_port *ap)

so that it can be converted to the proper logging system? I'm asking not 
because it is open source but because you probably might have some other 
interface design considerations or concerns that I (mostly) can't know of and 
an interface change is not an option.

--
Regards,
Boris.