Re: [PATCH] ide-timing.h: make the timing from the IDE device work
From: Vojtech Pavlik <hidden>
Date: 2005-02-12 09:21:58
On Thu, Aug 19, 2004 at 03:48:57PM +0800, Albert Lee wrote:
ide-timing.h patch: make the timing from the IDE device work. Albert Lee
Bartolomiej, we indeed need this patch, otherwise EIDE timings the drive supplies to us are completely ignored in the code.
quoted hunk ↗ jump to hunk
--- linux-2.6.6\drivers\ide\ide-timing.h.ori 2004-05-10 10:32:28.000000000 +0800 +++ linux-2.6.6\drivers\ide\ide-timing.h 2004-08-19 13:01:17.117860800 +0800@@ -220,6 +220,7 @@ if (!(s = ide_timing_find_mode(speed))) return -EINVAL; + memcpy(t, s, sizeof(*t)); /* * If the drive is an EIDE drive, it can tell us it needs extended * PIO/MWDMA cycle timing.@@ -248,7 +249,7 @@ * Convert the timing to bus clock counts. */ - ide_timing_quantize(s, t, T, UT); + ide_timing_quantize(t, t, T, UT); /* * Even in DMA/UDMA modes we still use PIO access for IDENTIFY, S.M.A.R.T
-- Vojtech Pavlik SuSE Labs, SuSE CR