Hi,

On Wed, 19 Jan 2005 12:42:19 +0100, Christoph Hellwig [off-list ref] wrote:

On Sat, Jan 15, 2005 at 02:37:36AM +0100, Bartlomiej Zolnierkiewicz wrote:

quoted

On Sun, 9 Jan 2005 14:19:59 +0100, Christoph Hellwig [off-list ref] wrote:

quoted

PCI probe routines (and funcions called by them) must use __devinit
as they can be called from PCI hotplug operations.

While most of the drivers touched in the patch are for hardware that's
soldered on mainboards we now have a fake PCI HP driver that allows
hot remove / replug for them which they need to handle.

Heh, hot remove is unsupported currently so this is not a problem
at the moment.  I queued your patch to be merged after hotplug is fixed.

quoted

Ugh... I really hate (lack of) flexibility of CONFIG_HOTPLUG...

Shouldn't we have __fakedev{init,exit} ?

This really gets a little too complex.  We also tended to trade a tiny
bit of vasted memory over complexity all the time in Linux's past..

 
agreed