Re: simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: 2005-01-28 22:56:41
On Fri, 28 Jan 2005 16:54:49 -0600, Doug Maxey [off-list ref] wrote:
On Fri, 28 Jan 2005 23:32:53 +0100, Bartlomiej Zolnierkiewicz wrote:quoted
quoted
The datacenters/server folks that would be using these drives would expect them to remain as set. I have to check, but unless something has changed very recently in the kernel, setting with hdparm does not "stick" in the sense that the command succeeds to the disk, but no change is made to the barrier.It is not a problem for IDE driver (flushes become no-ops) and this way you can later enable wcache and still use barries.Well that certainly simplfies things. How about this?
No go until 'drive->wcache' bug is fixed.
quoted hunk ↗ jump to hunk
===== drivers/ide/ide-disk.c 1.115 vs edited =====--- 1.115/drivers/ide/ide-disk.c 2005-01-04 11:39:25 -06:00 +++ edited/drivers/ide/ide-disk.c 2005-01-28 16:48:24 -06:00@@ -1083,7 +1083,7 @@ static void idedisk_setup (ide_drive_t * if ((id->csfo & 1) || (id->cfs_enable_1 & (1 << 5))) drive->wcache = 1; - write_cache(drive, 1); + write_cache(drive, drive->wcache); /* * We must avoid issuing commands a drive does not understand