Re: PATCH: switch ide-proc to use the ide_key functionality
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2004-08-16 23:23:11
Also in:
lkml
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2004-08-16 23:23:11
Also in:
lkml
On Monday 16 August 2004 17:30, Alan Cox wrote:
On Mon, Aug 16, 2004 at 05:24:09PM +0200, Bartlomiej Zolnierkiewicz wrote:quoted
This patch removes write access to /proc/ide/hd?/driver without even mentioning this - IMHO we should deprecate it first. Such changes should be described (with rationale for them) at least in the changelog (or even better in Documentation/ide.txt).I thought we discussed this earlier - its essentially unfixable. You can either have trivial /proc crashes, deadlocks on writing this file or lose the feature (which nobody on the planet even knew about).
I used this 'feature' few times and never experienced crash or deadlock but they are possible of course.
If you've got any ideas how to fix it then let me know. Agreed about adding it to Documentation/ide.txt
I fully agreed on the change but not the way in which it's done. ;-)