On Saturday 12 of June 2004 12:34, Christoph Hellwig wrote:

On Fri, Jun 11, 2004 at 05:50:30PM +0200, Bartlomiej Zolnierkiewicz wrote:

quoted

Probably some drivers are still missed because I changed only
these drivers that I knew that there are PCI cards using them.

If you know about PCI cards using other drivers please speak up.

IMHO the PCI ->probe methods should always be __devinit.  It's rather
hard to make sure they're never every hotplugged in any way, especially
with the dynamic id adding via sysfs thing.

I generally agree but IMO it makes no sense for i.e. piix.c.