Re: Possibly wrong BIO usage in ide_multwrite
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2004-01-05 17:06:10
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2004-01-01 · Re: Possibly wrong BIO usage in ide_multwrite · Andre Hedrick <hidden>
On Monday 05 of January 2004 04:52, Christophe Saout wrote:
BTW, what was ide_multwrite expected to return? These if clauses in multwrite_intr are never executed.
Dunno. It can't fail so it should be made void. Please also add bio->bi_idx restoring for failed requests. Put it before DRIVER(drive)->error() (and remember about if (bio) check). Otherwise I patch is OK for me. --bart