Thread (10 messages) 10 messages, 5 authors, 2003-10-16

Re: [PATCH] Poll-based IDE driver

From: Dave Jones <hidden>
Date: 2003-10-08 16:49:39
Also in: lkml

Possibly related (same subject, not in this thread)

On Wed, Oct 08, 2003 at 09:36:36AM -0700, Andre Hedrick wrote:
 > 
 > Does not matter, priority is to get content to platter and the hell with
 > everything else.

I don't buy this. Without correct udelay()'s, how is code like this..

        for (i = 0; i < 10; i++) {
                dump_udelay(1);
                if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad))
                        return 0;
        } 

expected to work ? It won't wait for 10usec at all, but be over almost instantly.
Ramming commands at the drive before its status has settled doesn't strike
me as a particularly safe thing to do.

		Dave

-- 
 Dave Jones     http://www.codemonkey.org.uk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help