Thread (11 messages) 11 messages, 6 authors, 2002-08-30

Re: ide-2.4.20-pre4-ac2.patch

From: Alan Cox <hidden>
Date: 2002-08-29 22:53:47
Also in: lkml

On Tue, 2002-08-27 at 23:17, Andre Hedrick wrote:
This is out and has been forwarded to AC for review.
Rejected. I found several errors, a couple of strange reverts and some
files being moved to clearly wrong places. It also mixes up multiple
changes.

Andre to make this work I need
	- One change per patch (within reason)
	- An explanation of what it does

For example I've got files you moved and changed, looking at that in
diff is a right pita. I've got a big diff with errors in it (eg gayle in
ppc) I can't easily be sure I can cleanly drop parts of.

Lets start with the file moving. Send me a diff for the Config/Makefile
and a lit of the files to move and where. Gayle I think should be m68k
not ppc (actually Im pretty sure), CMD640 is PCI so why file it in
legacy. "legacy" I took to mean pre PCI rather than "I think its junk"
8)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help