Thread (4 messages) flat view 4 messages, 2 authors, 3d ago
WARM3d REVIEWED: 3 (3M)

1 review trailer (1 from subsystem maintainers).

[PATCH RESEND 1/2] media: i2c: isl7998x: Inline i2c_check_functionality() check

From: Thorsten Blum <blum@kernel.org>
Date: 2026-09-09 08:21:18
Also in: linux-media, lkml
Subsystem: intersil isl7998x video decoder driver, media input infrastructure (v4l/dvb), the rest · Maintainers: Michael Tretter, Mauro Carvalho Chehab, Linus Torvalds

Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
Wolfram, could you please apply this last conversion, since this patch
has not been applied yet despite several resends since April? Thanks.
---
 drivers/media/i2c/isl7998x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
index a77538d2343c..8244d4296a02 100644
--- a/drivers/media/i2c/isl7998x.c
+++ b/drivers/media/i2c/isl7998x.c
@@ -1460,8 +1460,7 @@ static int isl7998x_probe(struct i2c_client *client)
 	int nr_inputs;
 	int ret;
 
-	ret = i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA);
-	if (!ret) {
+	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) {
 		dev_warn(&adapter->dev,
 			 "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n");
 		return -EIO;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help