Re: [PATCH 1/4] dt-bindings: i2c Update PCA954x
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2021-12-14 11:13:58
Also in:
linux-devicetree, lkml
Hi Patrick, Thank you for the patch. On Tue, Dec 14, 2021 at 10:50:18AM +0100, Patrick Rudolph wrote:
quoted hunk ↗ jump to hunk
Add the Maxim MAX735x as supported chip to PCA954x and add an example how to use it. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- .../bindings/i2c/i2c-mux-pca954x.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+)diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml index 9f1726d0356b..bd794cb80c11 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml@@ -11,6 +11,7 @@ maintainers: description: The binding supports NXP PCA954x and PCA984x I2C mux/switch devices. + Compatible with Maxim MAX7356 - MAX7358 I2C mux/switch devices. allOf: - $ref: /schemas/i2c/i2c-mux.yaml#@@ -19,6 +20,9 @@ properties: compatible: oneOf: - enum: + - maxim,max7356 + - maxim,max7357 + - maxim,max7358 - nxp,pca9540 - nxp,pca9542 - nxp,pca9543@@ -40,6 +44,7 @@ properties: interrupts: maxItems: 1 + description: Only supported on NXP devices. Unsupported on Maxim MAX735x.
Could this be modelled by a YAML schema instead ? Something like
allOf:
- if:
properties:
compatible:
contains:
enum:
- maxim,max7356
- maxim,max7357
- maxim,max7358
then:
properties:
interrupts: false
(untested, it would be nice to use a pattern check for the compatible
property if possible)
quoted hunk ↗ jump to hunk
"#interrupt-cells": const: 2@@ -100,6 +105,41 @@ examples: #size-cells = <0>; reg = <4>; + rtc@51 { + compatible = "nxp,pcf8563"; + reg = <0x51>; + }; + }; + }; + }; + + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + i2c-mux@74 { + compatible = "maxim,max7357"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x74>; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + eeprom@54 { + compatible = "atmel,24c08"; + reg = <0x54>; + }; + }; + + i2c@7 { + #address-cells = <1>; + #size-cells = <0>; + reg = <7>; + rtc@51 { compatible = "nxp,pcf8563"; reg = <0x51>;
-- Regards, Laurent Pinchart