Thread (18 messages) 18 messages, 3 authors, 2021-11-30

Re: [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout

From: Wolfram Sang <wsa@kernel.org>
Date: 2021-11-29 12:54:38
Also in: linux-arm-kernel, lkml

Hi Alain,
quoted
quoted
+		stm32f7_i2c_wait_free_bus(i2c_dev);
This does only a controller reset, not a bus recovery with 9 toggling
pulses, or?
indeed. I might better rework this and at the same time introduce the
bus recovery mechanism via the bus recovery callback in this driver.
Please don't merge this patch and I will rework that.
Wait a sec. Resetting a controller at the end of a failed transfer might
make sense if the controller is otherwise in an confused state.

Full bus recovery (9 pulses) should be done at the beginning of a
transfer when SDA is low, though.

So, I'd actually suggest to apply this patch and add full bus recovery
based on SDA low at the beginning of a transfer seperately.

What do you think?

All the best,

   Wolfram

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help