Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL

[PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL · Shreeya Patel <hidden> · 2021-10-18
Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL · Linus Walleij <hidden> · 2021-10-24
Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL · kernel test robot <hidden> · 2021-11-10
Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL · Linus Walleij <hidden> · 2021-11-11
Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL · Andy Shevchenko <hidden> · 2021-11-11

From: Linus Walleij <hidden>
Date: 2021-11-11 20:40:45
Also in: linux-gpio, lkml, oe-kbuild-all

On Wed, Nov 10, 2021 at 10:16 AM kernel test robot [off-list ref] wrote:

   drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':

quoted

drivers/gpio/gpiolib.c:3068:15: error: 'struct gpio_chip' has no member named 'irq'

    3068 |         if (gc->irq.chip) {
         |               ^~

Right you need an #ifdef CONFIG_GPIOLIB_IRQCHIP in this
case I would try:

if (IS_ENABLED(CONFIG_GPIOLIB_IRQCHIP) && gc->irq.chip)

hoping the compiler is smart enough to deal with that
(but I'm not sure it is)

Yours,
Linus Walleij

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help