Thread (3 messages) 3 messages, 3 authors, 2021-11-29

Re: i2c: i801: Don't silently correct invalid transfer size

From: Wolfram Sang <wsa@kernel.org>
Date: 2021-11-29 08:56:44

On Sun, Nov 07, 2021 at 10:57:00PM +0100, Heiner Kallweit wrote:
If an invalid block size is provided, reject it instead of silently
changing it to a supported value. Especially critical I see the case of
a write transfer with block length 0. In this case we have no guarantee
that the byte we would write is valid. When silently reducing a read to
32 bytes then we don't return an error and the caller may falsely
assume that we returned the full requested data.

If this change should break any (broken) caller, then I think we should
fix the caller.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help