Thread (5 messages) 5 messages, 3 authors, 2021-10-22

Re: [PATCH v1 3/3] mfd: tps80031: Remove driver

From: Wolfram Sang <wsa@kernel.org>
Date: 2021-10-22 08:46:55
Also in: linux-rtc, lkml

It's I2C driver. I'm not sure about auto-probing because something
should provide information about device to Linux. It's possible to
detect/scan whether there is device sitting on I2C address, but there is
no auto-discovery mechanism, AFAIK.
Well, in general, it could be manually instantiated from userspace...
TPS80031 device will fail to bind to this driver because it explicitly
requires platform data which should be NULL if device is probed solely
by I2C ID.
..but I agree in this case. The driver has this code:

        if (!pdata) {
                dev_err(&client->dev, "tps80031 requires platform data\n");
                return -EINVAL;
        }

and git grep shows no user having platform data.

Shouldn't 'drivers/regulator/tps80031-regulator.c' and
'./rtc/rtc-tps80031.c' be removed as well?

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help