[PATCH 4/5] i2c: s3c2410: fix IRQ check
From: Sergey Shtylyov <hidden>
Date: 2021-06-23 21:01:22
Also in:
linux-samsung-soc
From: Sergey Shtylyov <hidden>
Date: 2021-06-23 21:01:22
Also in:
linux-samsung-soc
Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful). Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...
Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: Sergey Shtylyov <redacted>
---
drivers/i2c/busses/i2c-s3c2410.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/i2c/busses/i2c-s3c2410.c
===================================================================--- linux.orig/drivers/i2c/busses/i2c-s3c2410.c
+++ linux/drivers/i2c/busses/i2c-s3c2410.c@@ -1137,7 +1137,7 @@ static int s3c24xx_i2c_probe(struct plat */ if (!(i2c->quirks & QUIRK_POLL)) { i2c->irq = ret = platform_get_irq(pdev, 0); - if (ret <= 0) { + if (ret < 0) { dev_err(&pdev->dev, "cannot find IRQ\n"); clk_unprepare(i2c->clk); return ret;