Re: [PATCH v2] i2c: i801: Ensure that SMBHSTSTS_INUSE_STS is cleared when leaving i801_access
From: Wolfram Sang <wsa@kernel.org>
Date: 2021-06-20 20:59:25
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Wolfram Sang <wsa@kernel.org>
Date: 2021-06-20 20:59:25
On Sun, Jun 06, 2021 at 03:55:55PM +0200, Heiner Kallweit wrote:
As explained in [0] currently we may leave SMBHSTSTS_INUSE_STS set, thus potentially breaking ACPI/BIOS usage of the SMBUS device. Seems patch [0] needs a little bit more of review effort, therefore I'd suggest to apply a part of it as quick win. Just clearing SMBHSTSTS_INUSE_STS when leaving i801_access() should fix the referenced issue and leaves more time for discussing a more sophisticated locking handling. [0] https://www.spinics.net/lists/linux-i2c/msg51558.html Fixes: 01590f361e94 ("i2c: i801: Instantiate SPD EEPROMs automatically") Cc: stable@vger.kernel.org Suggested-by: Hector Martin <redacted> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-current, thanks!