Thread (3 messages) 3 messages, 3 authors, 2021-06-24

Re: [PATCH] i2c/imx: Fix some checkpatch warnings

From: Uwe Kleine-König <hidden>
Date: 2021-06-23 12:19:55
Also in: linux-arm-kernel, lkml

Hello,

On Wed, Jun 23, 2021 at 05:36:43PM +0900, Kwon Tae-young wrote:
quoted hunk ↗ jump to hunk
@@ -1395,7 +1386,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
 				platform_get_device_id(pdev)->driver_data;
 
 	/* Setup i2c_imx driver structure */
-	strlcpy(i2c_imx->adapter.name, pdev->name, sizeof(i2c_imx->adapter.name));
+	strscpy(i2c_imx->adapter.name, pdev->name, sizeof(i2c_imx->adapter.name));
TIL about strscpy. I'm not yet sure if I like it better than strlcpy in
this case, but the usage is correct for sure.

Reviewed-by: Uwe Kleine-König <redacted>
 	i2c_imx->adapter.owner		= THIS_MODULE;
 	i2c_imx->adapter.algo		= &i2c_imx_algo;
 	i2c_imx->adapter.dev.parent	= &pdev->dev;
-- 
2.17.1

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help