Thread (7 messages) 7 messages, 3 authors, 2021-04-02

Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

From: Zhou Yanjie <hidden>
Date: 2021-04-02 15:30:43
Also in: linux-mips, lkml, stable

Hi Wolfram,

On 2021/3/31 下午3:18, Wolfram Sang wrote:
Hi,
quoted
quoted
Any write operation? I wonder then why nobody noticed before?
The standard I2C communication should look like this:

Read:

device_addr + w, reg_addr, device_addr + r, data;

Write:

device_addr + w, reg_addr, data;


But without this patch, it looks like this:

Read:

device_addr + w, reg_addr, device_addr + r, data;

Write:

device_addr + w, reg_addr, device_addr + w, data;

This is clearly not correct.
Thanks for the additional information! I understand now. I added a bit
of this to the commit message of v2 to explain the situation.
Thanks!


Best regards!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help