On 22.02.21 23:14:15, Dejin Zheng wrote:

On Mon, Feb 22, 2021 at 11:56:08AM +0100, Robert Richter wrote:

quoted

On 20.02.21 00:46:49, Dejin Zheng wrote:

quoted

quoted

On 18.02.21 23:04:55, Dejin Zheng wrote:

quoted

quoted

quoted

+	if (!dr || !dr->enabled)

here checks whether the pci device is enabled.

What is the purpose of this? The device "is_managed" or not.

The device is managed or not by check whether "dr" is NULL. And
check the "dr->enabled" is for the PCI device enable. I think it
may not make sense to apply for irq vectors when PCI device is not
enabled.

I don't see how a disabled device affects in any way the release of
the irq vectors during device removal. dr is always non-null in case
the device is managed, a check isn't needed for that.

-Robert