Re: [PATCH v3 4/5] amba: Make the remove callback return void

From
Vinod Koul <vkoul@kernel.org>
Date
2021-01-26 18:13:25
Also in
alsa-devel, dmaengine, dri-devel, kvm, linux-crypto, linux-fbdev, linux-input, linux-mmc, linux-rtc, linux-serial, linux-spi, linux-watchdog, lkml
Reply to
Uwe Kleine-König, 2021-01-27
On 26-01-21, 17:58, Uwe Kleine-König wrote:
All amba drivers return 0 in their remove callback. Together with the
driver core ignoring the return value anyhow, it doesn't make sense to
return a value here.

Change the remove prototype to return void, which makes it explicit that
returning an error value doesn't work as expected. This simplifies changing
the core remove callback to return void, too.

Reviewed-by: Ulf Hansson <redacted>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Linus Walleij <redacted>
Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/amba/bus.c                                 | 5 ++---
 drivers/char/hw_random/nomadik-rng.c               | 3 +--
 drivers/dma/pl330.c                                | 3 +--
For dmaengine:

Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod
Thread (27 messages) 27 messages, 11 authors, last reply 2021-02-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help