Thread (12 messages) flat view 12 messages, 3 authors, 2021-01-18

Re: [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write

From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: 2021-01-14 14:05:05
Also in: lkml

I asked the original authors of this about the change, and apparently is
results in a stack size warning.  Arnd Bergmann ask for it to be changed
from what you are suggesting to what it currently is.  See:

https://www.lkml.org/lkml/2019/6/19/440

So apparently this change will cause compile warnings due to the size of
struct i2c_client.
Wow, didn't know that my patch was actually a revert. I replaced now the
stack usage with kmemdup and will have a second thought about this
patch. Thanks for the heads up!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help