Re: [PATCH v3 2/3] i2c: smbus: use get/put_unaligned_le16 when working with word data
From: Wolfram Sang <hidden>
Date: 2021-01-11 21:05:03
Also in:
lkml
You claim this was clearer. For me it is not. With the explicit assignment to msgbuf0[1] and msbbuf0[2] it is immediatly obvious to me what happens. Even though the endianness is explicitly mentioned in put_unaligned_le16, it takes a bit longer for me to understand what it does and which part of data->word ends up in which byte.
Seems like I am on Uwe's side again. For me, the current way is also more readable.
Attachments
- signature.asc [application/pgp-signature] 833 bytes