Re: [PATCH v3 04/22] i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error

[PATCH v3 00/22] Improvements for Tegra I2C driver · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 01/22] i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 01/22] i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer · Andy Shevchenko <hidden> · 2020-09-03
Re: [PATCH v3 01/22] i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 07/22] i2c: tegra: Use dev_err_probe() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 18/22] i2c: tegra: Reorder location of functions in the code · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 19/22] i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 20/22] i2c: tegra: Remove "dma" variable · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 17/22] i2c: tegra: Improve driver module description · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 22/22] i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 21/22] i2c: tegra: Initialization div-clk rate unconditionally · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 16/22] i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 15/22] i2c: tegra: Clean up whitespaces and newlines · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 14/22] i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 13/22] i2c: tegra: Check errors for both positive and negative values · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 13/22] i2c: tegra: Check errors for both positive and negative values · Andy Shevchenko <hidden> · 2020-09-03
[PATCH v3 12/22] i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 11/22] i2c: tegra: Remove likely/unlikely from the code · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 10/22] i2c: tegra: Drop '_timeout' from wait/poll function names · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 09/22] i2c: tegra: Clean up probe function · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 09/22] i2c: tegra: Clean up probe function · Andy Shevchenko <hidden> · 2020-09-03
Re: [PATCH v3 09/22] i2c: tegra: Clean up probe function · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 09/22] i2c: tegra: Clean up probe function · Andy Shevchenko <hidden> · 2020-09-03
Re: [PATCH v3 09/22] i2c: tegra: Clean up probe function · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 06/22] i2c: tegra: Improve formatting of function variables · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 08/22] i2c: tegra: Runtime PM always available on Tegra · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 05/22] i2c: tegra: Use reset_control_reset() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 05/22] i2c: tegra: Use reset_control_reset() · Andy Shevchenko <hidden> · 2020-09-03
Re: [PATCH v3 05/22] i2c: tegra: Use reset_control_reset() · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 04/22] i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 04/22] i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error · Andy Shevchenko <hidden> · 2020-09-03
Re: [PATCH v3 04/22] i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 02/22] i2c: tegra: Add missing newline before returns · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
[PATCH v3 03/22] i2c: tegra: Clean up messages in the code · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03
Re: [PATCH v3 03/22] i2c: tegra: Clean up messages in the code · Andy Shevchenko <hidden> · 2020-09-03
Re: [PATCH v3 03/22] i2c: tegra: Clean up messages in the code · Dmitry Osipenko <digetx@gmail.com> · 2020-09-03

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-09-03 14:59:21
Also in: linux-tegra, lkml

03.09.2020 14:09, Andy Shevchenko пишет:

On Thu, Sep 3, 2020 at 3:53 AM Dmitry Osipenko [off-list ref] wrote:

quoted

The tegra_i2c_flush_fifos() may fail and transfer should be aborted in
this case.

Sounds like a fix. To add to previous comment, fixes that are likely
to be backported should have Fixes: tags.

I'll reword the commit title and message in order to make it not to
sound like this is a bug fix. Thanks!

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help