Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller
From: Andy Shevchenko <hidden>
Date: 2018-02-26 18:18:08
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Andy Shevchenko <hidden>
Date: 2018-02-26 18:18:08
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Mon, Feb 26, 2018 at 7:51 PM, Ard Biesheuvel [off-list ref] wrote:
On 26 February 2018 at 17:16, Ard Biesheuvel [off-list ref] wrote:
Perhaps we could agree on the binding first? Currently, I have the following
Device (I2C0) {
Name (_HID, "SCX0003")
Name (_UID, Zero)
Name (_CRS, ResourceTemplate () {
Memory32Fixed (ReadWrite, SYNQUACER_I2C1_BASE, SYNQUACER_I2C1_SIZE) Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 197 } })
Name (_DSD, Package () // _DSD: Device-Specific Data
{
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package (2) { "socionext,pclk-rate", 62500000 },
}
})and I don't intend to add 'clock-frequency' here because it would be redundant anyway.
Right.
Does this look sane?
I can't say about property name, but otherwise yes. -- With Best Regards, Andy Shevchenko