Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
From: Wolfram Sang <hidden>
Date: 2017-08-17 16:30:00
Also in:
kernel-janitors, lkml
On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
From: Colin Ian King <redacted> The structure cht_wc_i2c_adap_driver is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static? Signed-off-by: Colin Ian King <redacted>
CCing Hans to ask him if he maybe wants to create a MAINTAINERS entry for this driver, so he'll get CCed for such patches? :)
quoted hunk ↗ jump to hunk
--- drivers/i2c/busses/i2c-cht-wc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c index fe5caf70c7fe..01c94c918d4c 100644 --- a/drivers/i2c/busses/i2c-cht-wc.c +++ b/drivers/i2c/busses/i2c-cht-wc.c@@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = { }; MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table); -struct platform_driver cht_wc_i2c_adap_driver = { +static struct platform_driver cht_wc_i2c_adap_driver = { .probe = cht_wc_i2c_adap_i2c_probe, .remove = cht_wc_i2c_adap_i2c_remove, .driver = {-- 2.11.0
Attachments
- signature.asc [application/pgp-signature] 833 bytes