Re: [PATCH v3 3/3] spi: acpi: Initialize modalias from of_compatible

On 01/23/2017 05:11 PM, Andy Shevchenko wrote:

On Mon, Jan 23, 2017 at 6:08 PM, Dan O'Donovan [off-list ref] wrote:

quoted

From: Crestez Dan Leonard <redacted>

When using devicetree spi_device.modalias is set to the compatible
string with the vendor prefix removed. For SPI devices described via
ACPI the spi_device.modalias string is initialized by acpi_device_hid.
When using ACPI and DT ids this string ends up something like "PRP0001".

Change acpi_register_spi_device to use the of_compatible property if
present. This makes it easier to instantiate spi drivers through ACPI
with DT ids.
+       /*
+        * Populate modalias from compatible property if available,
+        * otherwise use native ACPI information
+        */
+       if ((!adev->data.of_compatible) ||
+           acpi_of_modalias(adev, spi->modalias, sizeof(spi->modalias)))

Same comment as in patch 2.

Thanks for the feedback, Andy.  The check on of_compatible is redundant,
because its repeated in acpi_of_modalias(), so I'll remove it here (and
in patch 2) to reduce this to one line.  v4 on the way.

quoted

+               strlcpy(spi->modalias, acpi_device_hid(adev),
+                       sizeof(spi->modalias));

Could this be one line?

I couldn't see a way to reduce this to one line without exceeding 80
chars or adding another line somewhere else, so I'll leave this one as
it is if that's ok.