Re: [PATCH v4 5/5] i2c: designware: Cleaning comments and formatation
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2016-12-07 19:54:12
Also in:
linux-devicetree, lkml
On Wed, 2016-12-07 at 17:55 +0000, Luis Oliveira wrote:
- Missspelling, comment formatation and fix a string of the existing code
Good, but after addressing below comments: Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
quoted hunk ↗ jump to hunk
--- a/drivers/i2c/busses/i2c-designware-slave.c +++ b/drivers/i2c/busses/i2c-designware-slave.c@@ -70,8 +70,8 @@ int i2c_dw_init_slave(struct dw_i2c_dev *dev)/* Configure register access mode 16bit */ dev->accessor_flags |= ACCESS_16BIT; } else if (reg != DW_IC_COMP_TYPE_VALUE) { - dev_err(dev->dev, "Unknown Synopsys component type: " - "0x%08x\n", reg); + dev_err(dev->dev, + "Unknown Synopsys component type: 0x%08x\n", reg);
Keep indentation like some_call(param, param2, ... paramX, paramY, ...); It applies to all your new code you bring by this series.
quoted hunk ↗ jump to hunk
@@ -181,8 +181,10 @@ int i2c_dw_reg_slave(struct i2c_client *slave)return -EBUSY; if (slave->flags & I2C_CLIENT_TEN) return -EAFNOSUPPORT; - /* set slave address in the IC_SAR register, - * the address to which the DW_apb_i2c responds */ + /* + * set slave address in the IC_SAR register, + * the address to which the DW_apb_i2c responds
Again, Capital letter here, dot at the end of sentence. You may fix (if you want to) the rest of comment lines in entire driver.
+ */ __i2c_dw_enable(dev, false); dw_writel(dev, slave->addr, DW_IC_SAR);
-- Andy Shevchenko [off-list ref] Intel Finland Oy