Thread (11 messages) 11 messages, 1 author, 2016-08-19
STALE3571d
Revisions (3)
  1. v2 current
  2. v3 [diff vs current]
  3. v4 [diff vs current]

[PATCH v2 07/10] i2c: i2c-smbus: remove double warning message

From: Benjamin Tissoires <hidden>
Date: 2016-08-19 13:29:47
Also in: lkml
Subsystem: i2c subsystem, the rest · Maintainers: Wolfram Sang, Linus Torvalds

i2c_handle_smbus_host_notify() returns an error code when it fails.
If the caller wants to warn when an error is returned, we should not
partially warn in the function itself.

Signed-off-by: Benjamin Tissoires <redacted>

---

new in v2
---
 drivers/i2c/i2c-smbus.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
index 35e4f1a..819e5f2 100644
--- a/drivers/i2c/i2c-smbus.c
+++ b/drivers/i2c/i2c-smbus.c
@@ -347,7 +347,6 @@ int i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify,
 
 	if (host_notify->pending) {
 		spin_unlock_irqrestore(&host_notify->lock, flags);
-		dev_warn(&adapter->dev, "Host Notify already scheduled.\n");
 		return -EBUSY;
 	}
 
-- 
2.5.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help