Re: [PATCH v2] i2c: designware-baytrail: Fix the Kconfig dependency fix
From: Jean Delvare <hidden>
Date: 2016-08-26 15:40:45
Hi Wolfram, Jarkko, On Thu, 25 Aug 2016 22:24:25 +0200, Wolfram Sang wrote:
On Fri, Jul 22, 2016 at 10:24:03AM +0200, Jean Delvare wrote:quoted
Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies") claims that the "Baytrail driver" isn't tristate. But in fact there is no such thing as a "Baytrail driver", i2c-designware-baytrail is not a stand-alone driver but an optional addition to the i2c-designware-platform driver, and that driver *is* tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too. Signed-off-by: Jean Delvare <redacted> Fixes: b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies") Reviewed-by: Jarkko Nikula <redacted> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Randy Dunlap <redacted> Cc: David E. Box <david.e.box@linux.intel.com> Cc: Wolfram Sang <redacted>I applied a patch from Jarkko on 19.6.2016 which also changed the dependencies. Not sure if it is equal to your change, but this patch doesn't apply anymore.
As I understand it, Jarkko's patch sets the same dependencies my patch was setting, just expressed differently. So we are good, you can drop my patch. Thanks, -- Jean Delvare SUSE L3 Support