Thread (24 messages) 24 messages, 6 authors, 2016-07-25

Re: [v5] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2016-06-09 08:15:46
Also in: linux-acpi

On Wed, Jun 08, 2016 at 06:29:13PM +0200, Benjamin Tissoires wrote:
quoted
-	err = acpi_check_resource_conflict(&dev->resource[SMBBAR]);
-	if (err) {
+	err = i801_acpi_probe(priv);
+	if (err)
 		return -ENODEV;
-	}
I'd say that once this has been set, we need to call
acpi_remove_address_space_handler() in case of failure later (in the 2
returns after).
Indeed - I wonder how many mistakes one patch can contain :-(

Let me fix this and submit yet another version.
The rest looks OK to me.
Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help