Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2015-09-23 12:57:02
Also in:
linux-acpi, linux-gpio, lkml
On Wed, 2015-09-23 at 14:48 +0200, Thierry Reding wrote:
quoted
quoted
quoted
On Wed, Sep 23, 2015 at 11:41:26AM +0300, Andy Shevchenko wrote:quoted
On Tue, 2015-09-22 at 16:37 +0200, Thierry Reding wrote:quoted
On Tue, Sep 22, 2015 at 01:10:19PM +0300, Andy Shevchenko wrote:
quoted
quoted
quoted
.of_match_table = pca9685_dt_ids,Similarly to the above, this should use of_match_ptr(), which in turn will require #ifdef protection for the table to avoid warnings.Hmm... my patch do not touches that part. Perhaps another patch for this?Your patch does touch that part by removing the dependency on OF. That makes it possible to build this code with !OF, which in turn would make the OF match table unused.
Ah, you're right. Will amend this part as well. Thanks!
Thierry
-- Andy Shevchenko [off-list ref] Intel Finland Oy