On Sat, Sep 20, 2014 at 5:48 AM, Arnd Bergmann [off-list ref] wrote:

On Friday 19 September 2014, Octavian Purdila wrote:

quoted

+struct dln2_gpio_pin {
+     __le16 pin;
+} __packed;

This does not need to be marked packed, since it is never embedded in another
structure.

Will do.

quoted

+struct dln2_gpio_pin_val {
+     __le16 pin;
+     u8 value;
+} __packed;

It's enough here to mark just the 'pin' member as packed.

OK.

quoted

+static int dln2_gpio_get_pin_count(struct platform_device *pdev)
+{
+     int ret;
+     __le16 count;
+     int len = sizeof(count);
+
+     ret = dln2_transfer(pdev, DLN2_GPIO_GET_PIN_COUNT, NULL, 0, &count,
+                         &len);

You must not do a USB transaction on stack memory.

dln2_transfer allocate a new buffer (in dln2_prep_buf(), with
kmalloc()) and does the USB transfer with that buffer.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html