Re: [PATCH v2] i2c: change the id to let the i2c-gpio work
From: Joachim Eastwood <hidden>
Date: 2012-10-12 17:42:16
Also in:
linux-arm-kernel
Hi Bo Shen, On Fri, Oct 12, 2012 at 11:42 AM, Bo Shen [off-list ref] wrote:
The i2c-gpio driver will turn the platform device ID to busnum. When using platfrom device ID as -1, it means dynamically assigned the busnum. When writing code, we need to make sure the busnum, and call i2c_register_board_info(int busnum, ...) to register device if using -1, we do not know the value of busnum. In order to solve this issue, set the platform device ID as a fix number Here using 0 to match the busnum used in i2c_regsiter_board_info().
I have been bitten by this myself on RM9200.
Signed-off-by: Bo Shen <redacted> --- Change since v1 Make the commit message more clear --- arch/arm/mach-at91/at91sam9260_devices.c | 2 +-
This pattern exist in at91rm9200_devices.c, at91sam9261_devices.c, at91sam9263_devices.c and at91sam9rl_devices.c you might want to fix them as well. I assume we have the same problem if CONFIG_I2C_AT91 is set? See further down in at91sam9260_devices.c we have another: ".id = -1," regards Joachim Eastwood
quoted hunk ↗ jump to hunk
1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c index 0f24cfb..805ef95 100644 --- a/arch/arm/mach-at91/at91sam9260_devices.c +++ b/arch/arm/mach-at91/at91sam9260_devices.c@@ -389,7 +389,7 @@ static struct i2c_gpio_platform_data pdata = { static struct platform_device at91sam9260_twi_device = { .name = "i2c-gpio", - .id = -1, + .id = 0, .dev.platform_data = &pdata, }; --1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel