On Wed, May 16, 2012 at 03:41:17PM +0200, Marek Vasut wrote:

Dear Felipe Balbi,

quoted

On Tue, May 15, 2012 at 10:23:37AM +0200, Marek Vasut wrote:

quoted

This codes connects the CI13xxx driver with the core found inside of
the Freescale i.MX244/i.MX28 CPU.

Signed-off-by: Marek Vasut <redacted>
Cc: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Detlev Zundel <redacted>
CC: Dong Aisheng <redacted>
CC: Fabio Estevam <redacted>
Cc: Felipe Balbi <redacted>
Cc: Greg Kroah-Hartman <redacted>
Cc: Linux ARM kernel <redacted>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: Sascha Hauer <redacted>
CC: Shawn Guo <redacted>
Cc: Stefano Babic <redacted>
CC: Uwe Kleine-König <redacted>
Cc: Wolfgang Denk <redacted>
Cc: Wolfram Sang <redacted>
---

 drivers/usb/chipidea/Makefile      |    4 +
 drivers/usb/chipidea/ci13xxx_mxs.c |  201
 ++++++++++++++++++++++++++++++++++++ 2 files changed, 205 insertions(+)
 create mode 100644 drivers/usb/chipidea/ci13xxx_mxs.c

diff --git a/drivers/usb/chipidea/Makefile

b/drivers/usb/chipidea/Makefile index cc34937..266d57d 100644

--- a/drivers/usb/chipidea/Makefile
+++ b/drivers/usb/chipidea/Makefile

@@ -12,3 +12,7 @@ endif

 ifneq ($(CONFIG_ARCH_MSM),)
 
 	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_msm.o
 
 endif

+
+ifneq ($(CONFIG_ARCH_MXS),)
+	obj-$(CONFIG_USB_CHIPIDEA)	+= ci13xxx_mxs.o
+endif

NAK... let it compile everywhere.

I just followed the pattern here, honestly I think this is quite OK so far. 
Further improvements can be made indeed.

why introduce something we know will change ? Just make sure your code
compiles everywhere. What's already there can be changed afterwards.

quoted

quoted

+	*data->pdev->dev.dma_mask = DMA_BIT_MASK(32);
+	data->pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);

why don't you just point to the parent's ?

Good idea, thanks :)

no problem ;-)

-- 
balbi