On Thursday 12 January 2012 03:46 AM, Kevin Hilman wrote:

Shubhrajyoti D [off-list ref] writes:

quoted

The functions omap_i2c_unidle/idle are called from omap_i2c_runtime_resume
and omap_i2c_runtime_suspend which is compiled for CONFIG_PM_RUNTIME.
Make the omap_i2c_unidle/idle also depend on CONFIG_PM_RUNTIME flag.

I probably should've done this when I initially cleaned up the
callbacks, but since you're doing it...

rather than move the functions within the file, just remove the
functions and move the code into the runtime callbacks.

That may break the modularity of the code since the

omap_i2c_unidle is responsible for restore. I would have preferred to keep it separate.


Do you think  I could  rename   omap_i2c_unidle to 
omap_i2c_restore instead ?

However don't feel strongly about it either dif you still feel that it should be moved into runtime 
callbacks directly I am ok.
 

 
Kevin