Re: [PATCH 0/5] Generalize module_platform_driver
From: Greg KH <gregkh@suse.de>
Date: 2011-11-16 16:42:27
Also in:
linux-iio, linux-spi, lkml
On Wed, Nov 16, 2011 at 05:36:18PM +0100, Jean Delvare wrote:
On Wed, 16 Nov 2011 08:02:06 -0800, Greg KH wrote:quoted
On Wed, Nov 16, 2011 at 10:13:34AM +0100, Lars-Peter Clausen wrote:quoted
Grant Likely recently introduced the module_platform_driver macro which can be used to eliminate a few lines on boilerplate code in platform driver modules. The same approach can be used to do the same for other bus type drivers. The first patch of this series generalizes the module_platform_driver macro and introduces the module_driver macro. It is similar to module_platform_driver macro but has two additional parameters to pass in the driver register and unregister function. The intend is that this macro is used to construct bus specific macros for generating the driver register/unregister boilerplate code. The next two patches in this series add the module_i2c_driver and module_spi_driver macro which use the module_driver macro to generate the I2C and SPI driver boilerplate code. The last two patches convert the driver found in the IIO framework to use the new module_i2c_driver and module_spi_driver macros to demonstrate their potential and remove over 700 lines of code. While this series only introduces these kind of helper macros for I2C and SPI bus drivers the same scheme should be applicable to most other bus driver types. For example PCI and USB seem to be good candidates. It probably makes sense to merge the first three patches together. The last two can probably, since this is not urgent, wait until the first three have reached mainline.Nice, I like this, unless people object, I'll merge the first patch to the driver-core tree. I'll gladly take the i2c and spi patches as well if the subsystem maintainers there don't object, and I'll work on the USB patch as well.No objection from me (for i2c).
Wonderful, thanks for letting me know. greg k-h