Re: [PATCH] i2c: octeon: Make the timeout 1*HZ instead of 1 jiffy
From: Jean Delvare <hidden>
Date: 2011-01-24 12:14:34
Also in:
lkml
Hi Bernhard, On Mon, 24 Jan 2011 13:05:41 +0100, Bernhard Walle wrote:
quoted hunk ↗ jump to hunk
Since the timeout in the struct i2c_adapter use jiffies as unit and a timeout should be independent of CONFIG_HZ and most drivers that specify a timeout here use just HZ, change the i2c-octeon driver to use 1*HZ (which is a second), too. Signed-off-by: Bernhard Walle <redacted> --- drivers/i2c/busses/i2c-octeon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index 0fe1102..537a4ee 100644 --- a/drivers/i2c/busses/i2c-octeon.c +++ b/drivers/i2c/busses/i2c-octeon.c@@ -460,7 +460,7 @@ static struct i2c_adapter octeon_i2c_ops = { .owner = THIS_MODULE, .name = "OCTEON adapter", .algo = &octeon_i2c_algo, - .timeout = 2, + .timeout = HZ, }; /**
This is a large timeout value, much larger than any value the i2c-octeon driver was using today for any possible value of HZ. Wouldn't it make more sense to set it to HZ / 50, which is 2 for HZ = 100, leaving the setting unchanged for this common case at least? -- Jean Delvare