Thread (11 messages) 11 messages, 3 authors, 5d ago

RE: [PATCH v6 3/4] x86/irq: Use irq_chip_retrigger_hierarchy() in msi_set_affinity()

From: Michael Kelley <hidden>
Date: 2026-09-23 14:30:17
Also in: linux-iommu, linux-pci, lkml

From: Naman Jain <redacted> Sent: Tuesday, September 22, 2026 9:30 PM
quoted hunk ↗ jump to hunk
The irqchips used by msi_set_affinity() are initialized by
x86_init_dev_msi_info(), which sets their irq_retrigger() callback to
irq_chip_retrigger_hierarchy(). Call the hierarchy helper directly instead
of invoking it indirectly through the irqchip callback.

Suggested-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Shradha Gupta <redacted>
Reviewed-by: Thomas Gleixner <tglx@kernel.org>
Signed-off-by: Naman Jain <redacted>
---
 arch/x86/kernel/apic/msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c
index 66bc5d3e79db3..9160227b9b32a 100644
--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -137,7 +137,7 @@ msi_set_affinity(struct irq_data *irqd, const struct cpumask *mask, bool force)
 	 * IRR.
 	 */
 	if (lapic_vector_set_in_irr(cfg->vector))
-		irq_data_get_irq_chip(irqd)->irq_retrigger(irqd);
+		irq_chip_retrigger_hierarchy(irqd);

 	return ret;
 }
Reviewed-by: Michael Kelley <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help