Re: [PATCH v1 3/4] drm/hyperv: Drop useless empty remove callback

From
Uwe Kleine-König (The Capable Hub) <hidden>
Date
2026-07-20 13:48:40
Also in
dri-devel, lkml
Reply to
Thomas Zimmermann, 2026-07-02
Hello,

On Thu, Jul 02, 2026 at 08:45:14AM +0200, Thomas Zimmermann wrote:
Am 01.07.26 um 19:05 schrieb Uwe Kleine-König (The Capable Hub):
quoted
Having an empty remove callback is equivalent to no remove callback.
(The only minor difference is that with an empty remove callback
pm_runtime_get_sync() and pm_runtime_put_noidle() are called.)

Drop this useless function.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <redacted>
---
  drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 5 -----
  1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index e766d87b7a9d..e3f41336a831 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -45,10 +45,6 @@ static int hv_drm_pci_probe(struct pci_dev *pdev,
  	return 0;
  }
-static void hv_drm_pci_remove(struct pci_dev *pdev)
-{
It would be better to call drm_dev_unplug() from here.  With a bit more
work, the driver can have hot-unplug functionality.
I don't have the "hardware" and thus cannot test. So I won't tackle that
suggested quest.

Best regards
Uwe

Attachments

Thread (17 messages) 17 messages, 4 authors, last reply 2026-07-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help