Re: [RFC PATCH 00/20] mshv: enable kexec with Hyper-V donated pages and partitions

On Wed, Jun 03, 2026 at 10:25:58AM -0700, Jork Loeser wrote:

On Wed, 3 Jun 2026, Mike Rapoport wrote:

quoted

On Mon, Jun 01, 2026 at 01:09:41PM -0700, Jork Loeser wrote:

quoted

On Sun, 31 May 2026, Mike Rapoport wrote:

quoted

quoted

Patch 19:      Export kexec_in_progress for modules

Isn't there another way to differentiate kexec reboot?

There's that "kexec reboot" string passed as the cmd to the reboot
notifier.
Maybe we can make it somehow more well defined API and use it?

A string? Dear my - the compiler won't flag it on an API change then, not
ideal clearly. What's wrong with exporting kexec_in_progress()?

The policy in general is avoid exports unless strictly necessary.
A string can be declared as const char *KEXEC_REBOOT = "kexec reboot" and
used in both kexec and mshv. Not ideal, but still better.

No strong feelings from my side, just EXPORT_SYMBOL there felt a bit off.
 

Best,
Jork

-- 
Sincerely yours,
Mike.