Re: [PATCH 3/3] x86/mm: Clarify should_flush_tlb() ordering

From
Dave Hansen <hidden>
Date
2025-05-23 17:23:41
Also in
lkml
Reply to
Peter Zijlstra, 2025-05-20
On 5/20/25 03:55, Peter Zijlstra wrote:
The ordering in should_flush_tlb() is entirely non-obvious and is only
correct because x86 is TSO. Clarify the situation by replacing two
WRITE_ONCE()s with smp_store_release(), which on x86 is cosmetic.

Additionally, clarify the comment on should_flush_tlb().
Thanks for clarifying the ordering in those comments. It's much
appreciated by us mere mortals!

Oh, and there are a few we's that snuck into the comments. But whoever
applies this can fix them up.

Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Thread (8 messages) 8 messages, 3 authors, last reply 2025-05-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help