On Wed, Mar 19, 2025 at 10:09:44PM +0100, Paolo Abeni wrote:

On 3/12/25 9:59 PM, Bobby Eshleman wrote:

quoted

@@ -753,6 +783,8 @@ static int vhost_vsock_dev_release(struct inode *inode, struct file *file)
 	virtio_vsock_skb_queue_purge(&vsock->send_pkt_queue);

 	vhost_dev_cleanup(&vsock->dev);
+	if (vsock->net)
+		put_net(vsock->net);

put_net() is a deprecated API, you should use put_net_track() instead.

quoted

 	kfree(vsock->dev.vqs);
 	vhost_vsock_free(vsock);
 	return 0;

Also series introducing new features should also include the related
self-tests.

Yes, I was thinking about testing as well, but to test this I think we 
need to run QEMU with Linux in it, is this feasible in self-tests?

We should start looking at that, because for now I have my own ansible 
script that runs tests (tools/testing/vsock/vsock_test) in nested VMs to 
test both host (vhost-vsock) and guest (virtio-vsock).

Thanks,
Stefano