Re: [PATCH 1/2] jiffies: Define secs_to_jiffies()
From: Easwar Hariharan <hidden>
Date: 2024-10-22 22:58:10
Also in:
linux-bluetooth, lkml
On 10/22/2024 11:53 AM, Easwar Hariharan wrote:
quoted hunk
There are ~500 usages of msecs_to_jiffies() that either use a multiplier value of 1000 or equivalently MSEC_PER_SEC. Define secs_to_jiffies() to allow such code to be less clunky. Suggested-by: Michael Kelley <redacted> Signed-off-by: Easwar Hariharan <redacted> --- include/linux/jiffies.h | 2 ++ net/bluetooth/hci_event.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h index 1220f0fbe5bf..50dba516fd2f 100644 --- a/include/linux/jiffies.h +++ b/include/linux/jiffies.h@@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m) } } +#define secs_to_jiffies(_secs) msecs_to_jiffies((_secs) * MSEC_PER_SEC) + extern unsigned long __usecs_to_jiffies(const unsigned int u); #if !(USEC_PER_SEC % HZ) static inline unsigned long _usecs_to_jiffies(const unsigned int u)diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 0bbad90ddd6f..7b35c58bbbeb 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c@@ -42,8 +42,6 @@ #define ZERO_KEY "\x00\x00\x00\x00\x00\x00\x00\x00" \ "\x00\x00\x00\x00\x00\x00\x00\x00" -#define secs_to_jiffies(_secs) msecs_to_jiffies((_secs) * 1000) - /* Handle HCI Event packets */ static void *hci_ev_skb_pull(struct hci_dev *hdev, struct sk_buff *skb,
Sorry, I should have combined distribution lists for the two patches, so everyone received both patches. Combining the lists with this email. Here's the lore link for the series: https://lore.kernel.org/all/20241022185353.2080021-1-eahariha@linux.microsoft.com/ (local) Thanks, Easwar