Thread (50 messages) 50 messages, 20 authors, 2024-06-03

Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue

From: Corey Minyard <hidden>
Date: 2024-03-28 19:52:27
Also in: asahi, dmaengine, imx, linux-arm-msm, linux-media, linux-mediatek, linux-mips, linux-mmc, linux-omap, linux-rdma, linux-renesas-soc, linux-riscv, linux-s390, linux-sunxi, linux-tegra, linux-usb, linuxppc-dev, lkml, netdev

On Thu, Mar 28, 2024 at 12:41:22PM -0700, Allen wrote:
quoted
quoted
quoted
I believe that work queues items are execute single-threaded for a work
queue, so this should be good.  I need to test this, though.  It may be
that an IPMI device can have its own work queue; it may not be important
to run it in bh context.
  Fair point. Could you please let me know once you have had a chance to test
these changes. Meanwhile, I will work on RFC wherein IPMI will have its own
workqueue.

 Thanks for taking time out to review.
After looking and thinking about it a bit, a BH context is still
probably the best for this.

I have tested this patch under load and various scenarios and it seems
to work ok.  So:

Tested-by: Corey Minyard <redacted>
Acked-by: Corey Minyard <redacted>

Or I can take this into my tree.

-corey
 Thank you very much. I think it should be okay for you to carry it into
your tree.
Ok, it's in my for-next tree.  I fixed the directory reference, and I
changed all the comments where you changed "tasklet" to "work" to
instead say "workqueue".

-corey
- Allen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help