Re: [PATCH v2 1/7] kunit: Handle thread creation error
From: Rae Moar <hidden>
Date: 2024-03-05 20:57:48
Also in:
kvm, linux-hardening, linux-security-module, linux-um, lkml
On Fri, Mar 1, 2024 at 2:40 PM Mickaël Salaün [off-list ref] wrote:
Previously, if a thread creation failed (e.g. -ENOMEM), the function was called (kunit_catch_run_case or kunit_catch_run_case_cleanup) without marking the test as failed. Instead, fill try_result with the error code returned by kthread_run(), which will mark the test as failed and print "internal error occurred...".
Hello! I have tested this and this fix looks good to me. Thanks! -Rae Reviewed-by: Rae Moar <redacted>
quoted hunk ↗ jump to hunk
Cc: Brendan Higgins <redacted> Cc: David Gow <redacted> Cc: Rae Moar <redacted> Cc: Shuah Khan <skhan@linuxfoundation.org> Reviewed-by: Kees Cook <redacted> Signed-off-by: Mickaël Salaün <mic@digikod.net> Link: https://lore.kernel.org/r/20240301194037.532117-2-mic@digikod.net (local) --- Changes since v1: * Added Kees's Reviewed-by. --- lib/kunit/try-catch.c | 1 + 1 file changed, 1 insertion(+)diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c index f7825991d576..a5cb2ef70a25 100644 --- a/lib/kunit/try-catch.c +++ b/lib/kunit/try-catch.c@@ -69,6 +69,7 @@ void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context) try_catch, "kunit_try_catch_thread"); if (IS_ERR(task_struct)) { + try_catch->try_result = PTR_ERR(task_struct); try_catch->catch(try_catch->context); return; } --2.44.0