Thread (3 messages) 3 messages, 3 authors, 2024-02-01

Re: [PATCH V2 net] hv_netvsc: Fix race condition between netvsc_probe and netvsc_remove

From: patchwork-bot+netdevbpf@kernel.org
Date: 2024-02-01 16:40:27
Also in: linux-rdma, lkml, netdev, stable

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Tue, 30 Jan 2024 23:35:51 -0800 you wrote:
In commit ac5047671758 ("hv_netvsc: Disable NAPI before closing the
VMBus channel"), napi_disable was getting called for all channels,
including all subchannels without confirming if they are enabled or not.

This caused hv_netvsc getting hung at napi_disable, when netvsc_probe()
has finished running but nvdev->subchan_work has not started yet.
netvsc_subchan_work() -> rndis_set_subchannel() has not created the
sub-channels and because of that netvsc_sc_open() is not running.
netvsc_remove() calls cancel_work_sync(&nvdev->subchan_work), for which
netvsc_subchan_work did not run.

[...]
Here is the summary with links:
  - [V2,net] hv_netvsc: Fix race condition between netvsc_probe and netvsc_remove
    https://git.kernel.org/netdev/net/c/e0526ec5360a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help