Re: [PATCH v1 1/3] x86/tdx: Check for TDX partitioning during early TDX init
From: Borislav Petkov <bp@alien8.de>
Date: 2023-11-29 16:41:28
Also in:
lkml, stable
On Wed, Nov 22, 2023 at 06:19:20PM +0100, Jeremi Piotrowski wrote:
Which approach do you prefer?
I'm trying to figure out from the whole thread, what this guest is.
* A HyperV second-level guest
* of type TDX
* Needs to defer cc_mask and page visibility bla...
* needs to disable TDX module calls
* stub out tdx_accept_memory
Anything else?
And my worry is that this is going to become a mess and your patches
already show that it is going in that direction because you need to run
the TDX side but still have *some* things done differently. Which is
needed because this is a different type of guest, even if it is a TDX
one.
Which reminds me, we have amd_cc_platform_vtom() which is a similar type
of thing.
And the TDX side could do something similar and at least *try* to
abstract away all that stuff.
Would it be nice? Of course not!
How can one model a virt zoo of at least a dozen guest types but still
keep code sane... :-\
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette