Re: [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

On Fri, Oct 27, 2023 at 4:43 PM Andrew Lunn [off-list ref] wrote:

quoted

+/**
+ * ethtool_puts - Write string to ethtool string data
+ * @data: Pointer to start of string to update

Isn't it actually a pointer to a pointer to the start of string to
update?

I suppose.

FWIW, I just copy-pasted the sprintf doc and tweaked:
/**
 * ethtool_sprintf - Write formatted string to ethtool string data
 * @data: Pointer to start of string to update
 * @fmt: Format of string to write
 *
 * Write formatted string to data. Update data to point at start of
 * next string.
 */

quoted

+extern void ethtool_puts(u8 **data, const char *str);

        Andrew