Thread (19 messages) 19 messages, 8 authors, 2023-10-26

Re: [PATCH 3/3] checkpatch: add ethtool_sprintf rules

From: Joe Perches <joe@perches.com>
Date: 2023-10-25 23:53:18
Also in: intel-wired-lan, lkml, netdev

On Wed, 2023-10-25 at 23:40 +0000, Justin Stitt wrote:
Add some warnings for using ethtool_sprintf() where a simple
ethtool_puts() would suffice.

The two cases are:

1) Use ethtool_sprintf() with just two arguments:
quoted
      ethtool_sprintf(&data, driver[i].name);
OK.
or
2) Use ethtool_sprintf() with a standalone "%s" fmt string:
quoted
      ethtool_sprintf(&data, "%s", driver[i].name);
I'm rather doubt this is really desired or appropriate.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help